Rachelint commented on PR #11827: URL: https://github.com/apache/datafusion/pull/11827#issuecomment-2344061391
> Thank you @Rachelint -- this looks very cool . I am sorry for the delay in the review > > It is my understanding that this will allow aggregates that do not yet implement GroupsAccumulator to benefit from the intermediate aggregate state. > > Thus the primary benefit of this code is to make aggregates on such queries faster. > > Unfortunately I don't think we have any examples of such aggregates in the benchmarks (e.g. calculating median or approx_median). I will make a PR to add some to see if we can measure improvement of this PR > > cc @korowa Sounds great! And we can continue to improve the performance after having such benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
