andygrove commented on PR #26447: URL: https://github.com/apache/datafusion/pull/26447#issuecomment-6525293059
I looked into TPC-DS q15, and this PR doesn't change how it runs. Its three joins build on primary keys (`customer`, `customer_address` and `date_dim`), so no key repeats and nothing is grouped. The join metrics match main's. Running main and this PR alternately on an M3 Max (`release-nonlto`, 12 partitions) doesn't show the slowdown either. On this PR, q15's median time was 1.007x main's when run on its own (8 rounds of 5 iterations), and 0.988x within the full TPC-DS suite (4 rounds). There, the other queries were within 0.96x to 1.04x of main, apart from q72, which was 1.73x faster. The bot runs main and this PR once each, so the 6% on q15 looks like run-to-run noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
