2010YOUY01 commented on code in PR #26898: URL: https://github.com/apache/datafusion/pull/26898#discussion_r4419129458
########## datafusion/sqllogictest/test_files/grouping.slt: ########## @@ -123,6 +123,69 @@ LIMIT 10; statement ok RESET datafusion.execution.enable_migration_aggregate; +# A grouping set that leaves out a key fills that key with NULL, so properties Review Comment: nit: I find this comment more confusing than clarifying. Could we either remove it or explain it better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
