comphead commented on PR #7256: URL: https://github.com/apache/datafusion-comet/pull/7256#issuecomment-6512817355
A follow-up in 9c5dcd0d84 simplifies the last two rounds. The window serde no longer sends the keys its child reports past the ones the window requires. That also removes the `order.child.references` check mentioned above. Since `dc94ccf3d3`, `with_declared_order` extends a partial order at the upper window, so the upper window declares what it needs itself. That covers both the `(k)` then `(k, v)` stack and the alias case. Nothing else in a native plan relies on a declared order it did not send itself. A sort-based aggregate adds its own sort, and the others use a declared order only to run faster. So each operator now declares only the order it needs. The two stacked-window tests are now one, `stacked native windows over a sorted cache`. It runs a window by `k` under one by `(k, x)`, and a window by `k` under one by `a`, an alias of `k`. The lower windows now send only `k`. I also dropped the separate `EmptyExec` unit test, which `declared_order_extends_an_order_the_input_declares` now covers, and trimmed some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
