andygrove commented on code in PR #2689:
URL:
https://github.com/apache/datafusion-ballista/pull/2689#discussion_r4412577669
##########
ballista/scheduler/src/state/mod.rs:
##########
@@ -393,10 +393,13 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerState<T,
error!(
"Failed to launch new task, could not get executor
metadata: {e}"
);
- state
+ // Refund like the rejected-launch branch: the executor
+ // stays registered, so its reserved vcores must go
+ // back into the budget (see #2686).
+ let freed = state
Review Comment:
I went ahead and filed this as #2691, so no need to open one yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
