andygrove commented on PR #7311: URL: https://github.com/apache/datafusion-comet/pull/7311#issuecomment-6503891737
Thanks for the careful review. It was of the first commit, so some of this has moved; the current head is f1a3040db7. The fork `main` finding no longer has a code path to get wrong. A push to a fork's default branch runs nothing now (`Preflight` skips it, since it is a sync of commits the queue already tested), and a pull request opened from it gets a neutral "open the pull request from a branch" rather than a mirrored run. The stale baseline finding is right, and the "never fewer" claim was wrong. A fork push is now diffed against upstream `main` by `dev/ci/fork-push-changed-files.sh`, which is the diff the pull request will show. It lists every file when the fetch fails, there is no merge base, or the diff is empty. `dev/ci/test-fork-push-changed-files.py` builds real repositories for your native-revert case, code followed by docs, `git push fork main:my-fix`, an unreachable upstream and an empty diff. I checked that the revert test fails if the script goes back to diffing against the fork's own `main`, and that the fetch works on a runner with the checkout credentials removed. On the queue coverage, the docs, the workflows README and the workflow comments now say the queue runs the queue tier with path filters, and that the nightly-only and `run-*` suites are not part of it. The three inherited findings are outside this diff, so I have not touched `publish-to-maven.sh`, `publish_snapshot.yml` or `docs.yaml` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
