2010YOUY01 commented on PR #26843: URL: https://github.com/apache/datafusion/pull/26843#issuecomment-6485810995
> @2010YOUY01 If right your approach chooses random seeds, right? but my approach runs all the test in less amount. I do not think its over-engineered, cuz pretty sure u run fuzz test concurrently,r right? > > Anyways why do u want to trade test coverage with simplicity? My solution preserve the 5k test, I have added comment to explain stuff too. Adding a work-stealing pool for a single UT looks a bit too much. The total run time (aggregated exec time across all CPUs) don't change by parallelizing, and our CI resource can't afford to continuously add new UTs that each take 5 min to run. A better way is to make all fuzzing tests configurable by time budget: - per-PR CI: fuzzing for 10 min - daily CI: fuzzing for 1 hr Though more work to be done for that goal beyond that PR, I'll try to investigate further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
