andygrove commented on PR #7307:
URL:
https://github.com/apache/datafusion-comet/pull/7307#issuecomment-6480284337
Thanks for the review. I pushed 2c30c5762e with the suite changes above.
`CometInMemoryCacheSuite` now gets its zstd codec from
`CometCachedBatchHelper.compressionCodec("zstd")`, so all four places that
built Arrow's codec directly go through `CometZstdCompressionCodec`. I also
rewrapped a comment in `CachedBatchIpc` that was one character over the
scalastyle limit.
On Spark having the same exposure: agreed, I read the 19.0.0 bytecode and
`ArrowCompressionUtils` and `ArrowCachedBatchSerializer` both build
`ZstdCompressionCodec` directly (`ArrowCompressionUtils` is also on
`branch-4.1` with Arrow 18.3.0). I'll file the SPARK JIRA soon and will comment
here once it's filed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
