andygrove opened a new pull request, #2684: URL: https://github.com/apache/datafusion-ballista/pull/2684
# Which issue does this PR close? No issue filed. This is a small CI change. # Rationale for this change The Docker workflow runs `./dev/build-ballista-docker.sh` on every PR and every push to `main` that touches Rust code. That is a full release build of the scheduler, executor and result service, and it takes around 40 to 45 minutes per run. Outside of release tags the images are never pushed, so these runs only check that the images still build. The Dockerfiles just copy prebuilt binaries onto a base image, and the debug build in `rust.yml` already covers compilation. The only thing the PR run catches that nothing else does is breakage in the Docker artifacts themselves. # What changes are included in this PR? Changes to `.github/workflows/docker.yml`: - Pull requests only trigger the workflow when `dev/docker/**`, `dev/build-ballista-docker.sh`, `dev/build-ballista-executables.sh`, `dev/build-set-env.sh` or the workflow file changes. - Pushes to `main` no longer trigger it. - A nightly `schedule` (05:00 UTC) and `workflow_dispatch` are added. Together they catch Rust changes that break the image build, such as a renamed binary, within a day and before a release depends on them. These runs never publish, because the publish step only fires for release tag refs. - Release tag pushes are unchanged and still publish to ghcr. The `paths` filter on the tag push is removed because GitHub does not evaluate path filters for tag pushes. - The concurrency group is now keyed on `github.ref` instead of `github.sha`. Previously an RC tag and its final tag on the same commit, or a nightly run on the same commit, shared a group, so with `cancel-in-progress` one could cancel the other's publish. # Are there any user-facing changes? No. Published images are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
