paleolimbot commented on PR #26145: URL: https://github.com/apache/datafusion/pull/26145#issuecomment-6459743215
While I don't necessarily mind the approach here, I think it needs some justification for why it's needed over the simpler fox. This is a good workaround for when you don't control the ScalarUDF source code, but the actual bug here is that `return_field()` for case when and friends are dropping metadata. I put a note on the other PR as well, but I recently discovered `intersect_metadata_for_union()`. While I think it is also not perfect, it might be better to use it here to reduce the number of times we define this logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
