pepijnve commented on PR #26057: URL: https://github.com/apache/datafusion/pull/26057#issuecomment-6454499102
> I wonder what you think about following the DynamicFileCatalog approach and adding InformationSchema support as a wrapper. I'll need to give that some thought. In this PR I was just continuing on what was already there and didn't consider this alternative. > SHOW ... would still have to remain a rewrite into SELECT I think that would reintroduce the need for the global information schema and move the translation back into `sql/statement.rs` using strings. `SHOW TABLES` is simple enough, but `SHOW FUNCTIONS` for instance is something that we can implement much simpler with a little bit of code. By implementing the `show` statements as dedicated execution plans we gain the freedom to adjust those and the informations schema independently. Additionally, you get to still use those statements without needing to make the information schema visible in each catalog (i.e. the dependency on the config setting goes away). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
