Rich-T-kid commented on code in PR #26826:
URL: https://github.com/apache/datafusion/pull/26826#discussion_r4394895902
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -310,10 +359,58 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {
map_size: 0,
group_values,
hashes_buffer: Default::default(),
+ dictionary_hash_cache: Default::default(),
+ has_dictionary,
random_state: crate::aggregates::AGGREGATION_HASH_SEED,
})
}
+ fn create_hashes(&mut self, cols: &[ArrayRef], hashes: &mut [u64]) ->
Result<()> {
+ if !self.has_dictionary {
+ create_hashes(cols, &self.random_state, hashes)?;
Review Comment:
this gets re-used across all 3 PR's I think we should move it up into the
hash util PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
