cetra3 commented on code in PR #26630:
URL: https://github.com/apache/datafusion/pull/26630#discussion_r4384314326
##########
datafusion/common/src/dfschema.rs:
##########
@@ -846,6 +894,7 @@ impl DFSchema {
field_qualifiers: vec![None; self.inner.fields.len()],
inner: self.inner,
functional_dependencies: self.functional_dependencies,
+ name_index: self.name_index,
Review Comment:
Agreed. None of those callers are on the analyzer or optimizer paths, and in
most of them the source schema hasn't been probed, so sharing buys nothing. In
5d6c90691 the rewrites start with an empty index, so it only follows `Clone`,
and `merge` resets it. I've dropped the rewrite assertion from the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
