LinSimon-901101 commented on PR #5889: URL: https://github.com/apache/datafusion-comet/pull/5889#issuecomment-6420609102
Thanks @sunchao ,for the detailed review. The follow-up fixes are grouped into three commits: - **`2804b05` — Struct ownership, bounded memory, and vectorization.** Addresses the P2 issues around [[ordinary struct provenance](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085482)], [[unknown-child width protection](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085476)], [[physical boundaries](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085474)], [[stateful/expanding consumers](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085478)], [[numeric formatting](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085484)], and [[fixed-cardinality arrays](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085485)]. Resolved struct literals share ownership, unsafe consumers retain fallback, and supported bounded paths preserve batched execution. - **`ad80285` — Spark evaluation order and native Top-K.** Addresses the P2 issues involving [[dynamic IN](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085457)], [[AND/OR](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085460)], [[nullable operand order](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085463)], and [[generated concat](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085468)]. Also preserves Bloom initialization semantics and adds bounded native Top-K evaluation. Eligible ANSI INT/BIGINT Top-K paths remain native; all six multi-partition regressions pass with AQE on/off.. - **`ab9f41b` — Date and timestamp correctness.** Addresses the P2 issues with [[regional timezone clock extraction](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085470)] and [[scalar Date32-to-epoch conversion](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4367085473)], preserving supported native paths and using compatibility fallback where required. [[Full fork CI](https://github.com/LinSimon-901101/datafusion-comet/actions/runs/40330835868)] passed on the current PR head, `ab9f41b`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
