CuteChuanChuan opened a new pull request, #26717:
URL: https://github.com/apache/datafusion/pull/26717
## Which issue does this PR close?
- Closes #26148.
## Rationale for this change
See the issue. NLJ gets the same documented, loom-checked protocol as hash
join. No behaviour change intended.
## What changes are included in this PR?
- Move `probe_completion.rs` from `hash_join/` to `joins/`.
- Add `abandon(count) -> bool` for partitions that stop early.
- `report_completed()` returns `Completion { NotLast, Emit(summary),
Abandoned }`. An `Option` can't tell "not last" from "last, but someone
abandoned", and the latter must still release the visited bitmap.
- NLJ: `LeftSpillData` uses `ProbeCompletion` in place of its counter and
`incomplete` flag. The in-memory counter moves out of `JoinLeftData` into
`LeftLoad::InMemory`, so the per-chunk `JoinLeftData` has none.
## What is the testing strategy for this PR?
- New unit test for `abandon(0)` and a new loom test for `abandon`. The loom
test fails if `abandon`'s decrement is `Relaxed`.
- Existing NLJ/hash join unit tests, `joins.slt`,
`nested_loop_join_spill.slt` and `join_fuzz` pass.
Loom (not run by CI):
```
$ RUSTFLAGS="--cfg datafusion_loom" cargo test -p datafusion-physical-plan
--lib loom_tests
test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 2596 filtered out
```
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
