alamb commented on code in PR #12135:
URL: https://github.com/apache/datafusion/pull/12135#discussion_r1747635751
##########
datafusion/core/src/datasource/file_format/mod.rs:
##########
@@ -138,6 +139,33 @@ pub trait FileFormat: Send + Sync + fmt::Debug {
) -> Result<Arc<dyn ExecutionPlan>> {
not_impl_err!("Writer not implemented for this format")
}
+
+ /// Check if the specified file format has support for pushing down the
provided filters within
+ /// the given schemas. Added initially to support the Parquet file
format's ability to do this.
+ fn supports_filters_pushdown(
+ &self,
+ _file_schema: &Schema,
+ _table_schema: &Schema,
+ _filters: &[&Expr],
+ ) -> Result<FilePushdownSupport> {
+ Ok(FilePushdownSupport::NoSupport)
+ }
+}
+
+/// An enum to distinguish between different states when determining if
certain filters can be
+/// pushed down to file scanning
+#[derive(PartialEq)]
Review Comment:
I think it would be nice to derive `Debug` as well here
```suggestion
#[derive(Debug, PartialEq)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
