korowa opened a new pull request, #12360:
URL: https://github.com/apache/datafusion/pull/12360
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #11537.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
It turned out to be not a NLJoin issue, but fuzz tests -- during NLjoin
construction, join filter was completely ignored, and all NLjoin tests were
running with only equijoin conditions in filter.
In the same time filtered inner/left/right/full join fuzz tests were passing
even without the filter -- the reason is that they've been using
`less_than_100_join_filter`, which always returns True, as generation of input
data for column, used in this filter, always returns values less than 100 --
`make_staggered_batches` comment:
```
/// two sorted int32 columns 'a', 'b' ranged from 0..99 as join columns
```
so it seems to be more useful to place `col_lt_col_filter` in all tests,
since it has non 100% selectivity.
Finally, after replacing filter in all test cases, some of HjSmj tests
turned out to be flaky, so they are temporarily disabled, until #12359 fix.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- NLJoin construction in fuzz tests now takes into account join_filter, and
constructs composite filter as a union of join_filter and equijoin conditions,
all fuzz tests are enabled for NljHj case
- all `_filtered` test cases now use `col_lt_col_filter`
- some `_filtered` testcases disabled for SortMergeJoin due to their
flakiness
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No, it's related exclusively to the tests
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
