Kontinuation commented on PR #904: URL: https://github.com/apache/datafusion-comet/pull/904#issuecomment-2328336839
This fix looks correct. The dictionary vectors also [hold the reference counts](https://github.com/apache/arrow/blob/r-16.1.0/java/c/src/main/java/org/apache/arrow/c/ReferenceCountedArrowArray.java#L66) of the imported vector, so the reference count of the imported vector will never reach zero if we don't close these dictionary provider, thus causing memory allocated on the native side to be leaked. I've verified this fact with a test program written in C++ and Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
