jayzhan211 commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1742905343
##########
datafusion/functions/src/core/coalesce.rs:
##########
@@ -60,12 +60,16 @@ impl ScalarUDFImpl for CoalesceFunc {
}
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- Ok(arg_types[0].clone())
+ Ok(arg_types
+ .iter()
+ .find_or_first(|d| !d.is_null())
+ .unwrap()
+ .clone())
}
- // If all the element in coalesce is non-null, the result is non-null
+ // If all the elements in coalesce are non-null, the result is non-null
fn is_nullable(&self, args: &[Expr], schema: &dyn ExprSchema) -> bool {
- args.iter().any(|e| e.nullable(schema).ok().unwrap_or(true))
+ args.iter().all(|e| e.nullable(schema).ok().unwrap_or(true))
Review Comment:
I think the logic here is incorrect.
`e.nullable(schema)` is true if `nullable`, false if `non-null`.
Therefore, whenever we found at least one is `nullable`, we should returns
`true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
