comphead commented on PR #26266: URL: https://github.com/apache/datafusion/pull/26266#issuecomment-6276603562
Thanks, pushed `ac51d5844`. 1. Output is now capped at 2^24 generated rows per batch and fails with a resources error, including during constant folding. 2. An integer literal that fits `INT` now unifies with an `Int32` value in any position. 3. `n` is still limited to a bare literal. The return type is planned before folding, and `scalar_arguments` deliberately excludes expression casts. The error message and docs now say so. Nullability is ignored when matching types. Array lengths are checked against `number_rows`. The `tile` block boundaries have a unit test. I kept the strict cast, because overflowing the planned type should be an error. I kept `tile`, which measured about 3.5x faster than `take` for unpivot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
