github-actions[bot] commented on PR #25892: URL: https://github.com/apache/datafusion/pull/25892#issuecomment-6248552362
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.1.0 (current) Built [ 34.104s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.082s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 33.652s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.088s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.498s] 223 checks: 216 pass, 7 fail, 0 warn, 31 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_expr::expr::in_subquery_tuple_values, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/expr.rs:1417 function datafusion_expr::logical_plan::builder::table_scan_with_filter_and_fetch_and_skip, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/builder.rs:2249 function datafusion_expr::builder::table_scan_with_filter_and_fetch_and_skip, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/builder.rs:2249 function datafusion_expr::utils::passthrough_field_index, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/utils.rs:1033 function datafusion_expr::expr_schema::cast_subquery_columns, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/expr_schema.rs:847 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: LogicalPlanBuilder::table_scan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/builder.rs:523 LogicalPlanBuilder::table_scan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/builder.rs:523 LogicalPlanBuilder::table_scan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/builder.rs:523 LogicalPlanBuilder::table_scan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/builder.rs:523 TableScanBuilder::with_skip, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:3331 TableScanBuilder::with_skip, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:3331 Join::with_null_aware_value_keys, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:4751 Join::with_null_aware_value_keys, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:4751 CreateExternalCatalog::builder, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/ddl.rs:630 CreateExternalCatalog::builder, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/ddl.rs:630 DropCatalog::builder, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/ddl.rs:843 DropCatalog::builder, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/ddl.rs:843 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/module_missing.ron Failed in: mod datafusion_expr::logical_plan::materialized_cte, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:18 mod datafusion_expr::materialized_cte, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:18 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_expr::logical_plan::materialized_cte::MaterializedCteScan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:144 struct datafusion_expr::materialized_cte::MaterializedCteScan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:144 struct datafusion_expr::logical_plan::MaterializedCteScan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:144 struct datafusion_expr::MaterializedCteScan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:144 struct datafusion_expr::logical_plan::materialized_cte::MaterializedCte, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:69 struct datafusion_expr::materialized_cte::MaterializedCte, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:69 struct datafusion_expr::logical_plan::MaterializedCte, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:69 struct datafusion_expr::MaterializedCte, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:69 struct datafusion_expr::logical_plan::materialized_cte::MaterializedCteId, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:44 struct datafusion_expr::materialized_cte::MaterializedCteId, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:44 struct datafusion_expr::logical_plan::MaterializedCteId, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:44 struct datafusion_expr::MaterializedCteId, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/materialized_cte.rs:44 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron Failed in: field skip of struct TableScan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:3175 field skip of struct TableScan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:3175 field null_aware_value_keys of struct Join, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:4517 field null_aware_value_keys of struct Join, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/logical_plan/plan.rs:4517 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron Failed in: method supports_skip_pushdown of trait TableSource, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/expr/src/table_source.rs:122 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_parameter_count_changed.ron Failed in: ExprPlanner::plan_scalar now takes 1 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/planner.rs:269 Summary semver requires new major version: 7 major and 0 minor checks failed Finished [ 70.971s] datafusion-expr Building datafusion-sqllogictest v55.1.0 (current) Built [ 110.077s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 106.535s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.088s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: DataFusionSubstraitRoundTrip::with_optimization, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4e7bc058e40aebf60b0e0d900f41dd50e685fc3b/datafusion/sqllogictest/src/engines/datafusion_substrait_roundtrip_engine/runner.rs:60 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 219.814s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
