alamb commented on code in PR #12240:
URL: https://github.com/apache/datafusion/pull/12240#discussion_r1740099318
##########
datafusion/core/src/datasource/listing/helpers.rs:
##########
@@ -51,12 +51,12 @@ use object_store::{ObjectMeta, ObjectStore};
/// - the table provider can filter the table partition values with this
expression
/// - the expression can be marked as `TableProviderFilterPushDown::Exact`
once this filtering
/// was performed
-pub fn expr_applicable_for_cols(col_names: &[String], expr: &Expr) -> bool {
+pub fn expr_applicable_for_cols(col_names: &[&str], expr: &Expr) -> bool {
Review Comment:
This is a nice removal of some clones 👍
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -133,12 +134,15 @@ impl std::fmt::Display for BinaryExpr {
}
/// Invoke a boolean kernel on a pair of arrays
-macro_rules! boolean_op {
- ($LEFT:expr, $RIGHT:expr, $OP:ident) => {{
- let ll = as_boolean_array($LEFT).expect("boolean_op failed to downcast
array");
- let rr = as_boolean_array($RIGHT).expect("boolean_op failed to
downcast array");
- Ok(Arc::new($OP(&ll, &rr)?))
- }};
+#[inline]
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
