adriangb commented on code in PR #26056:
URL: https://github.com/apache/datafusion/pull/26056#discussion_r4264293360
##########
datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:
##########
@@ -343,6 +344,20 @@ impl DynamicFilterPhysicalExpr {
Ok(())
}
+ /// Reset this dynamic filter so its producer can publish a new expression
+ /// during a later execution of the same plan.
+ pub fn reset(&self) -> Result<()> {
+ self.update(lit(true))?;
+ let mut current = self.inner.write();
+ current.is_complete = false;
+ let generation = current.generation;
+ drop(current);
+ let _ = self
+ .state_watch
+ .send(FilterState::InProgress { generation });
Review Comment:
What's the point of this line? Do we need to add some sort of
`FilterState::Reset`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
