pingzh commented on code in PR #6827:
URL: https://github.com/apache/datafusion-comet/pull/6827#discussion_r4243163819
##########
native/spark-expr/src/conditional_funcs/case_when/tests.rs:
##########
@@ -0,0 +1,791 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
thanks @andygrove for reviewing, let me move it back. there isn't a
particular reason, i was trying to make the original file shorter via moving
out the tests
##########
native/spark-expr/src/conditional_funcs/case_when.rs:
##########
@@ -60,8 +59,17 @@ pub fn create_case_when(
.transpose()?
.unwrap_or(DataType::Null);
- let Some(coerce_type) = get_coerce_type_for_case_expression(&then_types,
Some(&else_type))
- else {
+ // Spark merges THEN types from left to right, with ELSE last, retaining
the first THEN's
Review Comment:
added. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
