andygrove commented on PR #6599: URL: https://github.com/apache/datafusion-comet/pull/6599#issuecomment-6087302521
I merged main in at 4c1e35ed1c so this can go into the queue. Two files conflicted. In `CometArrayContains`, main had added #6471's check that sends arrays with a non-default string collation through the codegen dispatcher, plus `hasConditionalNativeDefault`. I kept both, with the collation check ahead of your flat and nested float routing, and listed its reason next to yours. In `expressions.md` I kept main's "Hybrid" for `array_contains` and its collation note on `array_distinct`, and added collations to your routing description. Nothing else needed changing. Locally, `CometArrayExpressionSuite`, `CometFloatSemanticsSuite`, `CometMapExpressionSuite` and the `expressions/array/` fixtures passed on Spark 4.1 (600 tests), and the array and map suites passed on 3.4 (178). The `spark-expr` Rust tests pass, and clippy and `cargo fmt` are clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
