viirya commented on code in PR #890:
URL: https://github.com/apache/datafusion-comet/pull/890#discussion_r1736807640
##########
common/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala:
##########
@@ -215,12 +215,8 @@ object Utils {
val writer = new ArrowStreamWriter(root, provider,
Channels.newChannel(out))
writer.start()
writer.writeBatch()
-
root.clear()
- writer.end()
-
- out.flush()
- out.close()
+ writer.close()
Review Comment:
Closing the writer will close the dictionary provider. If the dictionary
arrays are shared across batches, you will close them and empty later batches.
I remember we hit the issue before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
