andygrove commented on PR #6348: URL: https://github.com/apache/datafusion-comet/pull/6348#issuecomment-5997658144
Thanks @parthchandra, I added that note to the `CometDays` doc comment in 536b259da. The edge turned out to be narrower than any pre-1970 timestamp ending in 999999. Iceberg's wrap moves the instant back to the start of its second, so the day only changes when that second starts at midnight, for example `1969-01-01 00:00:00.999999`, which Iceberg puts on 1968-12-31. That's the same check `iceberg_div_floor` makes. `CometHours` floors the same way, so the comment says that too. I also merged main, which only conflicted on the `datetime.scala` imports, and added `run-iceberg-tests`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
