asolimando commented on PR #21122: URL: https://github.com/apache/datafusion/pull/21122#issuecomment-5970893039
> Thank you! It's always been on my list, though I've had some trouble allocating enough time to it. > > I'll share some partial feedback next week, and plan to focus on this project more deeply at some point later. @2010YOUY01 no worries, that's totally understandable. To save you time, I pushed [this branch](https://github.com/apache/datafusion/compare/main...asolimando:datafusion:asolimando/expression-synopsis) to my fork. It has the full implementation of #21120, which I used to validate the design. It keeps the expression-level rules to a minimum: just enough to show the framework's backbone and how operators and providers use it. The first PR (of five) would be commits 1-9: the synopsis type, the walk over the expression tree, the provider chain, and the aggregate as the first operator that uses them. If you only have time for part of the design at first, feedback on these would be a good start and unblock the first PR. Interval analysis is only used from the second PR, which adds the filter, so my question about it is less urgent. This is not a code review request, as the code will change based on our discussion, but it is probably easier to ask an LLM what I meant exactly when something is unclear. Looking forward to your feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
