andygrove commented on code in PR #6556: URL: https://github.com/apache/datafusion-comet/pull/6556#discussion_r4170121635
########## spark/src/test/resources/sql-tests/expressions/math/signum.sql: ########## @@ -27,3 +27,29 @@ SELECT signum(d) FROM test_signum -- literal arguments query SELECT signum(-5.0), signum(5.0), signum(0.0), signum(NULL) Review Comment: could you add `-0.0` literal to this query -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
