andygrove commented on code in PR #870: URL: https://github.com/apache/datafusion-comet/pull/870#discussion_r1735044816
########## native/spark-expr/src/cast.rs: ########## @@ -711,7 +728,11 @@ fn cast_array( /// Determines if DataFusion supports the given cast in a way that is /// compatible with Spark Review Comment: `allow_incompat` is an internal API so I don't think we need to add antyhing to the user guide. We do already have documentation for the `spark.comet.cast.allowIncompatible` config, which is used to populate `allow_incompat`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
