andygrove opened a new pull request, #6529:
URL: https://github.com/apache/datafusion-comet/pull/6529

   ## Which issue does this PR close?
   
   Part of #5639.
   
   ## Rationale for this change
   
   Issue #5639 proposes splitting `planner.rs` into focused modules before 
extracting the planner crate. The Iceberg and Parquet write planning paths are 
self-contained and are a natural next step in that decomposition.
   
   ## What changes are included in this PR?
   
   - Move the `IcebergWrite` and `ParquetWriter` planning logic into 
`planner/write.rs`.
   - Implement and register `IcebergWriteBuilder` and `ParquetWriterBuilder` 
through the operator registry.
   - Preserve the existing planning behavior and writer configuration unchanged.
   
   ## How are these changes tested?
   
   - `cargo fmt --all`
   - `cargo check -p datafusion-comet --all-targets`
   - `DYLD_LIBRARY_PATH="$(/usr/libexec/java_home -v 17)/lib/server" cargo test 
-p datafusion-comet --lib` (544 passed, 5 ignored)
   - `cargo clippy --color=never --all-targets --workspace -- -D warnings`
   - `make core`
   - `./mvnw test -Dtest=none 
-Dsuites="org.apache.comet.parquet.CometParquetWriterSuite,org.apache.comet.CometIcebergWriteActionSuite"`
 (130 passed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to