comphead commented on code in PR #6516: URL: https://github.com/apache/datafusion-comet/pull/6516#discussion_r4160263300
########## .ai/skills/review-comet-expression-pr/SKILL.md: ########## @@ -103,6 +106,12 @@ Location: `native/spark-expr/src/`, registered in `comet_scalar_funcs.rs`. - [ ] No panics. Use `Result`. - [ ] Batch operations rather than row-by-row where a kernel exists - [ ] Invalid UTF-8 going into a native `StringType` goes through `decode_utf8_spark_lossy` +- [ ] An aggregate merges partial states in Spark's order of operations, not just with Spark's + buffer layout. A different floating-point order fails Spark's exact checks, such as `m2 == 0`, Review Comment: should we be that sepcific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
