NoahKusaba opened a new pull request, #2519:
URL: https://github.com/apache/datafusion-ballista/pull/2519
## Which issue does this PR close?
None. This fixes CI, which is currently failing on every open PR (e.g.
#2518).
## Rationale for this change
`rust-toolchain.toml` uses the `stable` channel, and CI picked up Rust
1.99.0 (released 2026-09-28). Its clippy, run with `-D warnings`, now fails on
code already on `main`:
```
error: the borrowed expression implements the required traits
--> ballista/core/src/serde/mod.rs:1419:46
--> ballista/core/src/serde/mod.rs:1420:46
```
Once `ballista-core` passes, `ballista-scheduler`'s test build fails too:
```
error: use of deprecated method
`std::sync::atomic::Atomic::<usize>::fetch_update`: renamed to `try_update` for
consistency
--> ballista/scheduler/src/state/task_manager.rs:1201:18
```
## What changes are included in this PR?
- `core/src/serde/mod.rs`: `.map(&scalar_to_proto)` →
`.map(scalar_to_proto)` (two lines).
- `scheduler/src/state/task_manager.rs` (test mock only): keep
`fetch_update` and add `#[allow(deprecated)]` to that one statement.
`try_update` only exists from Rust 1.99, and the workspace `rust-version` is
1.94.0, so renaming would break builds at MSRV.
## Are there any user-facing changes?
No.
## What is the testing strategy for this PR?
- All three commands in `ci/scripts/rust_clippy.sh` pass with Rust 1.99.0
(`--keep-going`, so every crate was checked, not just up to the first failure).
- `cargo fmt --check` is clean, and the affected `ballista-core` serde and
`ballista-scheduler` `task_manager` tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
