andygrove opened a new pull request, #34:
URL: https://github.com/apache/datafusion-iceberg/pull/34
## Which issue does this PR close?
- Closes #33.
## Rationale for this change
Other DataFusion repositories give coding agents repository-specific
instructions in an `AGENTS.md`. This repository has none, so agents have to
work out how CI builds and tests the code, and they miss conventions that
aren't visible from any single file.
## What changes are included in this PR?
- `AGENTS.md`, covering:
- the checks CI runs, which should pass before committing, and how to run
a single unit test, integration test or sqllogictest schedule
- conventions that are easy to miss: `unused_qualifications = "deny"`,
rustfmt's `max_width = 90`, the toolchain version pinned in two places, and ASF
license headers
- the catalog → schema → table provider hierarchy, the read path and the
soundness rule for `Inexact` filter pushdown, the `INSERT` pipeline, and error
conversion
- the sqllogictest harness: schedules, `default.default.<table>` names,
pre-created tables, and hand-maintained `EXPLAIN` expectations
- the iceberg-rust git dependency and Arrow/Parquet version alignment
- `CLAUDE.md` as a symlink to `AGENTS.md`, as in apache/datafusion,
apache/datafusion-comet and apache/datafusion-python.
The file describes `main` as it is today. #32 renames the crate and adds a
RAT license check, so whichever of the two lands second will update `AGENTS.md`
for those changes. RAT reads the `CLAUDE.md` symlink as a file without a
license header, so #32 also excludes it, as Comet and datafusion-python do.
## What is the testing strategy for this PR?
This PR only adds documentation. I ran each command it documents against
this branch. The targeted unit, integration and sqllogictest runs pass,
`UPDATE_EXPECT=1` leaves the tree unchanged, and the playground starts with an
`--rc` file and runs a query.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
