viirya commented on code in PR #878:
URL: https://github.com/apache/datafusion-comet/pull/878#discussion_r1734114405
##########
spark/src/main/scala/org/apache/spark/shuffle/sort/RowPartition.scala:
##########
@@ -30,7 +30,11 @@ class RowPartition(initialSize: Int) {
rowSizes += size
}
- def getNumRows: Int = rowAddresses.size
+ def getNumRows: Int = if (rowAddresses == null) {
+ 0
+ } else {
+ rowAddresses.size
+ }
Review Comment:
This is unrelated. Just when I tested several memory configs to try to
trigger spilling, this method throws NPE sometimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
