rluvaton commented on code in PR #25877: URL: https://github.com/apache/datafusion/pull/25877#discussion_r4145739362
########## datafusion/physical-plan/src/aggregates/aggregate_hash_table/storage.rs: ########## @@ -0,0 +1,575 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Flat or blocked storage for the group keys and accumulator states of an +//! aggregate table. +//! +//! Every part of a table chooses its storage on its own, once, when the table +//! is created: the group keys use [`BlockedGroupValues`] when their type +//! supports it (see [`use_blocked_keys`]), and each aggregate uses a +//! [`BlockedGroupsAccumulator`] when it has one. Everything else keeps today's +//! flat [`GroupValues`] and [`GroupsAccumulator`], unchanged, so any mix of +//! flat and blocked parts works, and a table with no blocked part runs exactly Review Comment: thanks, fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
