findepi commented on PR #12197: URL: https://github.com/apache/datafusion/pull/12197#issuecomment-2313056495
Note 1: clippy doesn't seem to find all unnecessary clones (https://github.com/apache/datafusion/pull/12196#issuecomment-2312847864) Note 2 Running `cargo clippy -- -Aclippy::all -Wclippy::needless_pass_by_value` reports quite many functions which today move arguments but could take reference. Addressing these could potentially lead to some more cloning becoming unnecessary (and fixable with clippy). However clippy's `--fix` doesn't seem to work with `needless_pass_by_value` for me, this may require manual work. Not sure this is worth it, maybe the compiler can figure it all out on its own? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
