sergiimk opened a new issue, #25883:
URL: https://github.com/apache/datafusion/issues/25883

   ### Describe the bug
   
   In `v55.0.0` the PR #21767 added the [`preserve_order` 
feature](https://github.com/apache/datafusion/blob/2cac713274496ba8ee08e58655e80f0d464f6d48/datafusion/physical-plan/Cargo.toml#L90)
 to `serde_json` dependency in `datafusion-physical-plan`.
   
   This feature replaces `BTreeMap`-backed `serde_json::Value` with an 
`IndexMap` **globally**.
   
   This is a major side-effect for applications embedding `datafusion`:
   - It can affect performance
   - It makes REST API return keys in different order
   - It impacts many tests that may have depended on sorted keys
   - It affects our cryptography that relies on stable sorted JSON 
representation.
   
   Enabling this feature just doesn't seem like a choice that a library should 
make as its effects are disruptive and non-local.
   
   ### To Reproduce
   
   -
   
   ### Expected behavior
   
   I suspect `preserve_order` is only needed for testing and could be enabled 
in `dev-dependencies` without affecting applications that link `datafusion`. CC 
@adriangb
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to