alamb commented on issue #12114: URL: https://github.com/apache/datafusion/issues/12114#issuecomment-2312549471
> > > As I think, can we run the basic aggregation without any optimizations enabled and use its output as expected first, > > > and then we modify the options to enable different optimizations and their combinations, and compare their result with expected? > > > > > > Yes, I think that is likely a good plan. In my mind, as long as all the code paths get the same answer that will increase our confidence that the system is computing the correct results in the different places > > Ok, maybe just start from making a simple sketch, and try to impl current aggr fuzz tests based on it? > > I can have a try on it, and help to push forward about enabling #11943 by default, Thank you -- that would be awesome. I can't keep up anymore with everything that is going on In terms of helping along DataFusion performance, my plan was to focus first on getting StringView enabled and then switch more to focusing on the blocked intermediate state. I will however, prioritize time for reviewing aggregation testing as I think testing in general is really important for DataFusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
