dwsmith1983 commented on issue #5580: URL: https://github.com/apache/datafusion-comet/issues/5580#issuecomment-5873080834
> I am happy to contribute non-overlapping tests in a focused follow-up if the maintainers prefer to proceed with #5867. @LinSimon-901101 you took this on 09-11 and #5867 went up the same afternoon with the same `CodegenDispatchFallback` change on `CometMapExtract` and `CometElementAt`, so the serde part overlaps. #5867 is approved and waiting on CI. #5875 has pieces #5867 does not: `map_lookup_dispatch.sql`, `element_at_map_ansi.sql`, the dispatcher on and off arms in `CometCodegenDispatchBenchmark`, and the audit notes. Once #5867 lands, those fit as a follow-up on top of it, and I will not duplicate them there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
