andygrove commented on issue #1381: URL: https://github.com/apache/datafusion-comet/issues/1381#issuecomment-5872256472
Closing this, since the loop it was about is gone. The interval check's `Instant::now()` used to run on every spin of the busy-poll loop in `executePlan`. #2940 cut that to once per 100 polls, and #6219 replaced the busy loop with one that parks while it waits on native I/O. What's left is one clock read per output batch and one per pending poll. Each of those sits next to a JNI handoff, a pull from the JVM or a wake-up that costs far more than the read. Most DataFusion operators also read the clock twice per batch for their own metrics, and `coarsetime` can't reach those, so switching this one call would add a dependency without a measurable gain. Happy to reopen if a profile says otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
