andygrove commented on issue #2787: URL: https://github.com/apache/datafusion-comet/issues/2787#issuecomment-5870661485
Since #5236, CometExecRule lifts fallback reasons recorded on an operator's expressions onto the operator when it stays in Spark, so a HashAggregate that falls back on a result expression now also shows that expression's own reason, including the allowIncompatible hint. The q92 plan from the description no longer falls back at all, because double-to-decimal casts are now compatible and incompatible casts go through the codegen dispatcher. I think this can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
