andygrove commented on PR #6306: URL: https://github.com/apache/datafusion-comet/pull/6306#issuecomment-5872155049
Closing this rather than taking it into 1.1.0. On `branch-1.1` the native Iceberg scan is on by default and the native writer is off, so in practice this changes the default read path, and the saving there is small. For S3, GCS and OSS the shared `FileIO` only avoids re-parsing the storage config and, with a custom credential provider, rebuilding the JNI bridge, because iceberg-rust still creates a new operator per file open. The HDFS client reuse that motivated #6106 needs #5898, which isn't in this release, and nothing in CI exercises the S3 path end to end. That's not a trade I want on the release branch. @sunchao thanks for the review, this isn't about anything in the change itself. #6106 is already on `main`, so it ships in the next release from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
