wiedld commented on issue #12118: URL: https://github.com/apache/datafusion/issues/12118#issuecomment-2311396274
There is a [long discussion over here](https://github.com/substrait-io/substrait/discussions/2) about the type system in subtrait. The summary outcome (also reflected in [the spec here](https://substrait.io/types/type_system/)) is that we have logical type "string" and different variations for the physical type (e.g. uft8 vs largeutf8 vs utf8view). I've passing tests using this approach; want to check code coverage on a few things before putting up the PR (a.k.a. it looks like the largeutf8 variation was not fully implementation everywhere -- so I want to make sure we have full test coverage). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
