findepi commented on code in PR #12177:
URL: https://github.com/apache/datafusion/pull/12177#discussion_r1731536711
##########
datafusion/sql/src/unparser/rewrite.rs:
##########
@@ -86,22 +86,48 @@ pub(super) fn normalize_union_schema(plan: &LogicalPlan) ->
Result<LogicalPlan>
}
/// Rewrite sort expressions that have a UNION plan as their input to remove
the table reference.
-fn rewrite_sort_expr_for_union(exprs: Vec<Expr>) -> Result<Vec<Expr>> {
- let sort_exprs: Vec<Expr> = exprs
- .into_iter()
- .map_until_stop_and_collect(|expr| {
- expr.transform_up(|expr| {
- if let Expr::Column(mut col) = expr {
- col.relation = None;
- Ok(Transformed::yes(Expr::Column(col)))
- } else {
- Ok(Transformed::no(expr))
- }
- })
+fn rewrite_sort_expr_for_union(_exprs: Vec<SortExpr>) -> Result<Vec<SortExpr>>
{
+ // TODO FIXME
Review Comment:
known remaining
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
