andygrove commented on PR #6128: URL: https://github.com/apache/datafusion-comet/pull/6128#issuecomment-5799208733
Updated the `grow` item in `review-comet-memory-pr` to say a new `grow` call site is potential unbacked memory: a shortfall now becomes overcommit that Spark doesn't know about, and nothing caps it short of the container, so it's only justified for memory that already exists. I also scoped the partial-grant item under it to `try_grow`, since `grow` now keeps a partial grant as overcommit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
