mkleen opened a new pull request, #25384: URL: https://github.com/apache/datafusion/pull/25384
## Which issue does this PR close? - Closes #25375 ## Rationale for this change Override `AggregateUDFImpl::distinct_handling` on the Spark aggregates to match what their accumulators actually do: - `collect_set`: `Insensitive`, the accumulator always deduplicates, so `EliminateAggregateDistinct` can drop a redundant `DISTINCT`. - `collect_list`, `try_sum`: `Unsupported`, the accumulators ignore `is_distinct` and silently return the non-distinct result. - `avg`: `Unsupported`, the accumulator rejects `DISTINCT` with an error. ## What changes are included in this PR? see above. ## What is the testing strategy for this PR? - unit tests asserting each function's tag - a sqllogictest showing `collect_set(DISTINCT x)` is planned as `collect_set(x)`. ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
