andygrove commented on PR #5934: URL: https://github.com/apache/datafusion-comet/pull/5934#issuecomment-5687513783
Third-round feedback addressed in 4b71ad9; each inline thread has a reply. On the comment volume: trimmed in 4b71ad9. The module doc, the `lib.rs` header, the bench header and the test docs now keep only the invariants: why `dealloc` settles before delegating, why `IN_TRACK` is const-initialized and destructor-free, why post-hoc `realloc` accounting is safe here but not under enforcement, and why the thread-exit test is confined to the default build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
