kazantsev-maksim commented on PR #5416: URL: https://github.com/apache/datafusion-comet/pull/5416#issuecomment-5639182985
I dropped `scratch` from the three helpers (clippy is clean), extended `benches/split.rs` with the `limit` and regex axes, and reworded the description so the −65% on `limit_0` reads as the correctness fix it is rather than an allocation win — the one thing I won't call noise is the +2.3–3.4% regression on `regex` at 8192/65536 rows (p < 0.05), which I'm currently tracing to the buffer pre-allocation sized from `value_data().len()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
