Xuanwo opened a new pull request, #25182:
URL: https://github.com/apache/datafusion/pull/25182

   ## Which issue does this PR close?
   
   No linked issue; follows up on missing license headers found during release 
review.
   
   ## Rationale for this change
   
   Several SQL logic test files lack ASF license headers, and the existing 
license check only selects Rust, Python, and TypeScript files. Include SQL 
logic tests in that check to catch missing headers in future changes.
   
   ## What changes are included in this PR?
   
   - Add ASF headers to 18 SQL logic test files, including `sort_pushdown.slt`, 
`datetime/arith_timestamp_duration.slt`, `datetime/arith_time_interval.slt`, 
and `parquet_cdc_config.slt`.
   - Select all `*.slt` files and map the extension to HawkEye's `script` 
comment style.
   - Normalize 406 existing headers and their spacing to the canonical format 
required by HawkEye 7.0.0. SQL statements and expected results are unchanged.
   
   ## What is the testing strategy for this PR?
   
   - The existing license check covers all 517 SQL logic test files and passes 
with no unsupported files.
   - Temporarily removing a header from both a top-level and a nested SQL logic 
test makes the CI license check fail; restoring the headers makes it pass.
   - Compare all modified SQL logic test bodies against the base commit, 
excluding leading blank lines: unchanged.
   - Full extended workspace test command passes (11,605 Rust tests passed, 8 
ignored, plus the SQL logic test runner).
   - `cargo fmt --all`, `cargo clippy --all-targets --all-features -- -D 
warnings`, and `./dev/rust_lint.sh`.
   
   ## Are there any user-facing changes?
   
   No. This changes license headers and CI coverage only.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to